[Celestica] Minerva: fan_service: Implement Minerva rack FSC new requ…#1090
Open
QiuyunXie wants to merge 1 commit intofacebook:mainfrom
Open
[Celestica] Minerva: fan_service: Implement Minerva rack FSC new requ…#1090QiuyunXie wants to merge 1 commit intofacebook:mainfrom
QiuyunXie wants to merge 1 commit intofacebook:mainfrom
Conversation
somasun
requested changes
Apr 20, 2026
Contributor
somasun
left a comment
somasun
left a comment
There was a problem hiding this comment.
@QiuyunXie - can you please elaborate what special mode is. Calling this feature special mode is confusing. We use this same binary across all platforms, and it is not clear what is specialMode here, and why it applies to janga/tahan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…irement
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Quanta thermal team and Meta thermal team have reached an agreement on the new requirements for Minerva rack FSC. Modify code and fan_service config file to implement the requirement as below:
Test Plan
Quanta thermal team has verified this modification on Minerva rack and it meets their requirements.
Also attach the Fan_service unit test logs on IceCube, SantaBarbara and Anacapa25:
Icecube_fan_service_log.txt
Santa_fan_service_log.txt
Anacapa25_fan_service_log.txt