Skip to content

feat: make kind chip clickable to filter logs by kind #9803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crackedhandle wants to merge 2 commits into
base: master
Choose a base branch
from
+72 −43
Open

feat: make kind chip clickable to filter logs by kind #9803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c0cb8
feat: make kind chip clickable to filter logs by kind
crackedhandle Apr 23, 2026
2a69142
fix: address review feedback on kind chip filter
crackedhandle Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/devtools_app/lib/src/screens/logging/_message_column.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'package:devtools_app_shared/ui.dart';
import 'package:flutter/material.dart';

import '../../shared/globals.dart';
import '../../shared/primitives/utils.dart';
import '../../shared/table/table.dart';
import '../../shared/table/table_data.dart';
Expand Down Expand Up @@ -54,7 +55,6 @@ class MessageColumn extends ColumnData<LogData>
// This needs to be a function because the details may be computed after the
// initial build.
bool hasDetails() => !data.details.isNullOrEmpty;

return FutureBuilder<bool>(
future: data.detailsComputed.future,
builder: (context, _) {
Expand Down Expand Up @@ -92,7 +92,12 @@ class MessageColumn extends ColumnData<LogData>
padding: const EdgeInsets.symmetric(vertical: densePadding),
child: LayoutBuilder(
builder: (context, constraints) {
return MetadataChips(data: data);
return MetadataChips(
data: data,
onKindTapped: (kind) => screenControllers
.lookup<LoggingController>()
.setActiveFilter(query: 'k:"$kind"'),
);
},
),
),
Expand Down
106 changes: 65 additions & 41 deletions packages/devtools_app/lib/src/screens/logging/metadata.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ import '../../shared/primitives/utils.dart';
import 'logging_controller.dart';

class MetadataChips extends StatelessWidget {
const MetadataChips({super.key, required this.data});
const MetadataChips({super.key, required this.data, this.onKindTapped});

final LogData data;
final void Function(String kind)? onKindTapped;

@override
Widget build(BuildContext context) {
Expand Down Expand Up @@ -91,6 +92,7 @@ class MetadataChips extends StatelessWidget {
iconAsset: kindIcon.iconAsset,
backgroundColor: kindColors.background,
foregroundColor: kindColors.foreground,
onTap: onKindTapped != null ? () => onKindTapped!(data.kind) : null,
Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define the callback here directly instead of passing it in from the MetadataChips constructor. As is, there is an unnecessary level of abstraction to pass it in from MetadataChips.

),
logLevelChip,
if (elapsedFrameTimeAsString != null)
Expand All @@ -115,6 +117,7 @@ abstract class MetadataChip extends StatelessWidget {
this.foregroundColor,
this.outlined = false,
this.includeLeadingMargin = true,
this.onTap,
});

final IconData? icon;
Expand All @@ -125,6 +128,7 @@ abstract class MetadataChip extends StatelessWidget {
final Color? foregroundColor;
final bool outlined;
final bool includeLeadingMargin;
final VoidCallback? onTap;

static const horizontalPadding = densePadding;
static const verticalPadding = borderPadding;
Expand All @@ -140,50 +144,69 @@ abstract class MetadataChip extends StatelessWidget {
final foregroundColor =
this.foregroundColor ?? theme.colorScheme.onSecondaryContainer;

return maybeWrapWithTooltip(
tooltip: tooltip,
child: Container(
decoration: BoxDecoration(
color: backgroundColor,
borderRadius: BorderRadius.circular(_borderRadius),
border: outlined
? Border.all(color: theme.colorScheme.subtleTextColor)
: null,
),
margin: includeLeadingMargin
? const EdgeInsets.only(left: denseSpacing)
Widget chip = Container(
decoration: BoxDecoration(
color: backgroundColor,
borderRadius: BorderRadius.circular(_borderRadius),
border: outlined
? Border.all(color: theme.colorScheme.subtleTextColor)
: null,
padding: const EdgeInsets.symmetric(
horizontal: horizontalPadding,
vertical: verticalPadding,
),
child: Row(
mainAxisSize: MainAxisSize.min,
children: [
if (icon != null || iconAsset != null) ...[
DevToolsIcon(
icon: icon,
iconAsset: iconAsset,
size: _metadataIconSize,
color: foregroundColor,
),
const SizedBox(width: iconPadding),
] else
// Include an empty SizedBox to ensure a consistent height for the
// chips, regardless of whether the chip includes an icon.
const SizedBox(height: _metadataIconSize),
RichText(
text: TextSpan(
text: text,
style: theme
.regularTextStyleWithColor(foregroundColor)
.copyWith(fontSize: smallFontSize),
),
),
padding: const EdgeInsets.symmetric(
horizontal: horizontalPadding,
vertical: verticalPadding,
),
child: Row(
mainAxisSize: MainAxisSize.min,
children: [
if (icon != null || iconAsset != null) ...[
DevToolsIcon(
icon: icon,
iconAsset: iconAsset,
size: _metadataIconSize,
color: foregroundColor,
),
],
),
const SizedBox(width: iconPadding),
] else
// Include an empty SizedBox to ensure a consistent height for the
// chips, regardless of whether the chip includes an icon.
const SizedBox(height: _metadataIconSize),
RichText(
text: TextSpan(
text: text,
style: theme
.regularTextStyleWithColor(foregroundColor)
.copyWith(fontSize: smallFontSize),
),
),
],
),
);

if (onTap != null) {
chip = Padding(
padding: includeLeadingMargin
? const EdgeInsets.only(left: denseSpacing)
: EdgeInsets.zero,
child: MouseRegion(
cursor: SystemMouseCursors.click,
child: GestureDetector(
Comment on lines +191 to +193
Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use an Inkwell instead of MouseRegion + GestureDetector?

Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

furthermore, it should be possible to use an Inkwell with a null onTap handler that will behave as if the Inkwell were not present in the tree. This should make it possible to revert the changes above to store chip as a local variable and just define everything in the return statement.

onTap: onTap,
behavior: HitTestBehavior.opaque,
child: chip,
),
),
);
} else {
chip = Padding(
padding: includeLeadingMargin
? const EdgeInsets.only(left: denseSpacing)
: EdgeInsets.zero,
child: chip,
);
}

return maybeWrapWithTooltip(tooltip: tooltip, child: chip);
Comment thread
crackedhandle marked this conversation as resolved.
}
}

Expand All @@ -195,6 +218,7 @@ class KindMetaDataChip extends MetadataChip {
super.iconAsset,
super.backgroundColor,
super.foregroundColor,
super.onTap,
}) : super(text: kind, includeLeadingMargin: false);

static ({IconData? icon, String? iconAsset}) generateIcon(String kind) {
Expand Down