[GHSA-pw2r-vq6v-hr8c] Exposure of Sensitive Information to an Unauthorized Actor in follow-redirects#7473
Open
ljharb wants to merge 1 commit intoljharb/advisory-improvement-7473from
Open
Conversation
github-actions
Bot
changed the base branch from
main
to
ljharb/advisory-improvement-7473
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GHSA advisory metadata for follow-redirects to reflect that the vulnerable behavior starts at 0.0.4 (not all historical versions).
Changes:
- Updates the advisory
modifiedtimestamp. - Adjusts the
affected.rangeslower bound from"introduced": "0"to"introduced": "0.0.4".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
30
| "introduced": "0.0.4" | ||
| }, | ||
| { |
There was a problem hiding this comment.
The details field still states the issue affects follow-redirects "prior to 1.14.8", which now conflicts with the updated affected range starting at 0.0.4. Consider updating details (or adding a clarifying sentence) to reflect that versions 0.0.1–0.0.3 are not affected, so the narrative matches the affected.ranges data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Empirical POC-based runtime testing confirms follow-redirects 0.0.1-0.0.3 do not leak Authorization on HTTPS->HTTP scheme downgrade because the redirect code path (module.exports[proto].get(redirectUrl)) does not forward any headers from the original request. Versions 0.0.4+ started forwarding headers and do exhibit the scheme-downgrade leak.