[GHSA-jchw-25xp-jwwc] Follow Redirects improperly handles URLs in the url.parse() function#7474
Open
ljharb wants to merge 1 commit intoljharb/advisory-improvement-7474from
Open
[GHSA-jchw-25xp-jwwc] Follow Redirects improperly handles URLs in the url.parse() function#7474ljharb wants to merge 1 commit intoljharb/advisory-improvement-7474from
ljharb wants to merge 1 commit intoljharb/advisory-improvement-7474from
Conversation
github-actions
Bot
changed the base branch from
main
to
ljharb/advisory-improvement-7474
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GHSA advisory for follow-redirects to reflect corrected affected version boundaries based on empirical testing.
Changes:
- Adjusts the affected version range to indicate the issue is introduced in
0.0.6(not all versions). - Updates the advisory
modifiedtimestamp.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "events": [ | ||
| { | ||
| "introduced": "0" | ||
| "introduced": "0.0.6" |
There was a problem hiding this comment.
The affected range was narrowed to start at 0.0.6, but the details text still says "Versions ... before 1.15.4 are vulnerable", which now implies 0.0.1–0.0.5 are affected. Please update the details field to reflect the same introduced version (e.g., "from 0.0.6 before 1.15.4").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Empirical POC-based runtime testing confirms follow-redirects 0.0.1-0.0.5 do not exhibit the url.parse / WHATWG-URL differential. The try-new-URL / catch-url.parse fallback that makes this exploitable was introduced in 0.0.6 when the URL handling code path was rewritten. Prior versions used url.resolve + a simple redirect call with no WHATWG URL parsing step at all.