fix: resolve supply chain security code scanning alerts#2048
Merged
Conversation
zkoppert
force-pushed
the
fix/code-scanning-supply-chain-hardening
branch
from
7200204 to
a411cca
Compare
- Remove legacy Dockerfile (Ubuntu Trusty 14.04, Python 2, Ruby 2.4.1, references bintray.com which shut down 2021). It was never used by CI and generated recurring scanner alerts and dependabot noise. - Remove docker ecosystem from dependabot config since Dockerfile no longer exists. - Add --require-hashes --no-deps flags to pip install in CI workflow to enforce hash verification explicitly (alert #12). Resolves code scanning alerts #12, #14, #15, #16. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Zack Koppert <zkoppert@github.com>
zkoppert
force-pushed
the
fix/code-scanning-supply-chain-hardening
branch
from
a411cca to
15d84a1
Compare
There was a problem hiding this comment.
Pull request overview
This PR resolves supply-chain/security code scanning alerts by removing unused legacy Docker configuration and tightening Python dependency installation in CI.
Changes:
- Deleted the legacy
Dockerfileand removed.dockerignore(Docker build context no longer applicable). - Removed the Docker ecosystem entry from Dependabot configuration.
- Hardened CI Python installs by enforcing hash-checking and disabling dependency resolution for the pinned
docutilsinstall.
Show a summary per file
| File | Description |
|---|---|
Dockerfile |
Removed unused legacy Docker build definition that triggered multiple security alerts. |
.github/workflows/ci.yml |
Updated pip install command to use --require-hashes --no-deps for the pinned docutils requirement. |
.github/dependabot.yaml |
Dropped Docker ecosystem updates since there is no Dockerfile to monitor. |
.dockerignore |
Removed since Docker-related files were removed and it no longer serves a purpose. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 4 open code scanning alerts by removing the legacy Dockerfile (which caused 3 of the 4 alerts) and hardening the CI workflow's pip install.
Changes
dependabot.yaml— no Dockerfile to monitor anymore.--require-hashes --no-depsto pip install in CI — resolves alert Intelligently determine what file to render a README from if README.* isn't present #12. The requirements file already had inline hashes, but the explicit flag satisfies the scanner rule.Testing