chore(django-google-spanner): update Python version to 3.10#16914
chore(django-google-spanner): update Python version to 3.10#16914chalmerlowe wants to merge 3 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes support for Python 3.7, 3.8, and 3.9 across the project's configuration files, updating the minimum required version to 3.10 in both noxfile.py and setup.py. Feedback suggests adding PyPI classifiers for Python 3.13 and 3.14 to setup.py to ensure the metadata is consistent with the versions currently being tested in the Nox configuration.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/django-google-spanner/setup.py (76)
The noxfile.py configuration indicates that Python 3.13 and 3.14 are supported (though 3.14 is currently skipped due to Protobuf). To ensure consistency and proper indexing on PyPI, please add the corresponding classifiers for these versions in the classifiers list above.
| if session.python == "3.9": | ||
| session.skip("Python 3.9 is not supported for Django 5.2 tests") |
There was a problem hiding this comment.
nit: we should keep this until 3.9 is removed from gapic-generator and autogenerated packages which account for 90% of the packages in this repo.
There was a problem hiding this comment.
This PR and one's similar to it are blocked and are only presented for discussion.
Once the gapic-generator is updated fully to 3.10, these will be unblocked.
|
Switching to draft until presubmits are green |
2 participants
This PR updates
django-google-spannerto establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below.Changes
setup.pyandnoxfile.pyto require Python 3.10+ and remove references to Python 3.7, 3.8, and 3.9.noxfile.pythat was skipping Python 3.7.Blocking
This PR is blocked by PR #16910