Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated copy parameter from set_axis calls in blocks.py and dataframe.py. Feedback suggests that instead of using set_axis, which may still perform a copy in newer Pandas versions, the code should directly assign to the .columns attribute to ensure efficiency and avoid deprecation warnings.
|
|
||
| df = self._copy_index_to_pandas(raw_df).set_axis(self.column_labels, axis=1) |
There was a problem hiding this comment.
The copy parameter in set_axis is deprecated in recent Pandas versions. To avoid the warning and prevent an unnecessary full copy of the DataFrame (which set_axis performs by default in newer versions), it is recommended to assign directly to the .columns attribute. This is the official Pandas recommendation for replacing set_axis(..., copy=False) when modifying a fresh object.
| df = self._copy_index_to_pandas(raw_df).set_axis(self.column_labels, axis=1) | |
| df = self._copy_index_to_pandas(raw_df) | |
| df.columns = self.column_labels |
| if query_job: | ||
| self._set_internal_query_job(query_job) | ||
| return df.set_axis(self._block.column_labels, axis=1, copy=False) | ||
| return df.set_axis(self._block.column_labels, axis=1) |
There was a problem hiding this comment.
The copy parameter in set_axis is deprecated. To avoid the warning and prevent an unnecessary copy of the DataFrame, assign directly to the .columns attribute.
| return df.set_axis(self._block.column_labels, axis=1) | |
| df.columns = self._block.column_labels | |
| return df |
| "Cannot peek efficiently when data has aggregates, joins or window functions applied. Use force=True to fully compute dataframe." | ||
| ) | ||
| return maybe_result.set_axis(self._block.column_labels, axis=1, copy=False) | ||
| return maybe_result.set_axis(self._block.column_labels, axis=1) |
There was a problem hiding this comment.
The copy parameter in set_axis is deprecated. To avoid the warning and prevent an unnecessary copy of the DataFrame, assign directly to the .columns attribute.
| return maybe_result.set_axis(self._block.column_labels, axis=1) | |
| maybe_result.columns = self._block.column_labels | |
| return maybe_result |
1 participant
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue b/508671576 🦕