fix(ethereum): handle trace_filter traces missing result.output via c…#6535
Open
ibrahim1023 wants to merge 1 commit intographprotocol:masterfrom
Open
fix(ethereum): handle trace_filter traces missing result.output via c…#6535ibrahim1023 wants to merge 1 commit intographprotocol:masterfrom
ibrahim1023 wants to merge 1 commit intographprotocol:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6489
This PR fixes a regression where
trace_filterresponses fail to deserialize when a traceresultis missing theoutputfield (for example, some Sonic traces), causing repeated retries and trace ingestion failure.Root Cause
Graph Node now uses Alloy trace types for
trace_filterresponses. Some providers return traces whereresult.gasUsedis present butresult.outputis omitted. Alloy deserialization treats that as an invalidTraceOutputvariant and fails the entire response.What Changed
trace_filterrequest path unchanged for healthy responses.data did not match any variant of untagged enum TraceOutputtrace_filteras raw JSONresult.outputby injecting"output": "0x"whenresult.gasUsedexistsVec<LocalizedTransactionTrace>ethereum_adaptertests for:result.outputWhy This Is Safe
resultalready indicates execution output context (gasUsed) butoutputis omitted.Validation
Executed locally:
cargo test -p graph-chain-ethereum missing_output_trace_repro -- --nocapturecargo test -p graph-chain-ethereumResult: all tests passed (
50 passed, 0 failedforgraph-chain-ethereum).