Fix: JS grammar detects gql tags in comments#4087
Open
trevor-scheer wants to merge 4 commits intographql:mainfrom
Open
Fix: JS grammar detects gql tags in comments#4087trevor-scheer wants to merge 4 commits intographql:mainfrom
gql tags in comments#4087trevor-scheer wants to merge 4 commits intographql:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 331a2d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
approved these changes
Apr 21, 2026
dimaMachina
reviewed
Apr 21, 2026
| "devDependencies": { | ||
| "@vscode/vsce": "^2.22.1-2", | ||
| "ovsx": "^0.3.0", | ||
| "vitest": "^2.1.9", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "vitest": "^2.1.9", |
we already have vitest declared in root package.json?
Contributor
Author
There was a problem hiding this comment.
Yeah, I don't remember why I added this. I mentioned in the description I had some difficulty running vitest for this package but not sure what the issue was.
dimaMachina
approved these changes
Apr 21, 2026
trevor-scheer
force-pushed
the
ignore-tag-in-comment
branch
from
35b9cfa to
f2ef8a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a repro for now.
gqltags inside of comments are detected by the grammar and should probably be ignored. Anyone motivated to fix this: please feel free to push to this branch (if you're able) or pick my repro commit to another PR and close this one out.Had issues running
yarn vitestandyarn workspace vscode-graphql-syntax testso I addedvitestas a dev dependency (and matched the version the repo uses). Perhaps I'm missing the "right" way to run these tests.Also: not obvious to me why git is detecting the entire file changes, but hiding whitespace while reviewing reveals the actual diff in the snapshot correctly.