Skip to content

CDN Example: Add integrity metadata map and SRI hashes + Github Action to update#4100

Open
magicmark wants to merge 8 commits intographql:mainfrom
magicmark:patch-1
Open

CDN Example: Add integrity metadata map and SRI hashes + Github Action to update#4100
magicmark wants to merge 8 commits intographql:mainfrom
magicmark:patch-1

Conversation

@magicmark
Copy link
Copy Markdown

@magicmark magicmark commented Sep 9, 2025

This reference implementation will likely be copied and pasted in a bunch of places.

SRI hashes are important when loading from CDNs, so hopefully this improves security in a bunch of places :)

(I've verified manually this file still works)

I've also set up a github action to regenerate the example when:

  • on the released action for updated internal deps
  • scheduled cronjob for when external deps update

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 9, 2025

⚠️ No Changeset found

Latest commit: d3f1bb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@connorshea
Copy link
Copy Markdown
Contributor

Holy crap thank you, I was so frustrated trying to put this together myself when trying to integrate GraphiQL into my app where I use SRI for everything else. I hope this gets merged.

Copy link
Copy Markdown
Collaborator

@jonathanawesome jonathanawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @magicmark!

@magicmark magicmark changed the title CDN Example: Add integrity metadata map and SRI hashes CDN Example: Add integrity metadata map and SRI hashes + Github Action to update Oct 27, 2025
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thanks! Once I've got permissions sorted on this repo I'll get this merged. I literally just opened a related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants