Issue158#161
Conversation
|
|
||
| public BigDecimalCloseTo(BigDecimal value, BigDecimal error) { | ||
| this.delta = error; | ||
| this.delta = error.abs(); |
There was a problem hiding this comment.
is error null checked 1st, or should it be null checked?
There was a problem hiding this comment.
@nhojpatrick jap, checking this for null would be better.
There was a problem hiding this comment.
@StarBax89 this file now lives at ./hamcrest/src/main/java/org/hamcrest/number/BigDecimalCloseTo.java
if you rebase from the latest master, it should resolve the conflicts and I can merge in, e.g. git fetch origin && git rebase origin/master
|
@StarBax89 happy to look at getting merged as |
|
|
||
| public BigDecimalCloseTo(BigDecimal value, BigDecimal error) { | ||
| this.delta = error; | ||
| this.delta = error.abs(); |
There was a problem hiding this comment.
@nhojpatrick jap, checking this for null would be better.
|
|
||
| public IsCloseTo(double value, double error) { | ||
| this.delta = error; | ||
| this.delta = Math.abs(error); |
There was a problem hiding this comment.
@StarBax89 this file now lives at ./hamcrest/src/main/java/org/hamcrest/number/IsCloseTo.java
if you rebase from the latest master, it should resolve the conflicts and I can merge in, e.g. git fetch origin && git rebase origin/master
| @@ -6,9 +6,10 @@ | |||
| import static org.hamcrest.number.IsCloseTo.closeTo; | |||
|
|
|||
| public class IsCloseToTest extends AbstractMatcherTest { | |||
There was a problem hiding this comment.
@StarBax89 this file now lives at ./hamcrest/src/test/java/org/hamcrest/number/IsCloseToTest.java
if you rebase from the latest master, it should resolve the conflicts and I can merge in, e.g. git fetch origin && git rebase origin/master
|
Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch |
nhojpatrick
force-pushed
the
master
branch
2 times, most recently
from
9bc653b to
e9f7fc8
Compare
2 participants
Fixing
#158
with Math.abs