[#600] prevent case-sensitive testing with BETWEEN where infeasible#818
Open
d-w-moore wants to merge 1 commit intoirods:mainfrom
Open
[#600] prevent case-sensitive testing with BETWEEN where infeasible#818d-w-moore wants to merge 1 commit intoirods:mainfrom
d-w-moore wants to merge 1 commit intoirods:mainfrom
Conversation
korydraughn
reviewed
Apr 27, 2026
| def setUpClass(cls): | ||
| with helpers.make_session() as sess: | ||
| if cls._csq is None: | ||
| cls._csq = cls._query_columns_case_sensitive_by_default(sess) |
Contributor
There was a problem hiding this comment.
Why does case_sensitive_testing_feasible use a tuple to check cls._csq on line 64?
_query_columns_case_sensitive_by_default returns a boolean which removes the need for a tuple. Am I misunderstanding?
Contributor
|
It just occurred to me. Why does the PRC have tests which care about the database in use at all? Tests which care about that sort of thing should be part of the server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests using the
BETWEENoperator are now skipped if they are predicated on being case sensitive and if the installed object catalog ignores alphabetic case for query conditions dependent on lexical order (as tested byBETWEEN,>,>=,<, and<=.)