Fix for validating ECDSA signature.#41
Open
azure-hu wants to merge 1 commit intoitext:developfrom
Open
Conversation
…ryptionAlgorithms from SignatureMechanisms class found in itext-dotnet ver.7+ (https://github.com/itext/itext-dotnet/blob/develop/itext/itext.sign/itext/signatures/SignatureMechanisms.cs)
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside AcroFields.VerifySignature() a new PdfPKCS7 object has to be initialized, and it fails when signature is created with ECDSA. PdfPKCS7 ctor. calls InitSignature() which calls GetDigestAlgorithm() which calls GetEncryptionAlgorithm(). Because EncryptionAlgorithm.algorithmNames missing ECDSA related OIDs, therefore GetDigestAlgorithm() returns an unknown algorithm, e.g.: in case of ECDSA with SHA-512, the result is: "Sha512With1.2.840.10045.4.3.4".
This can be easily fixed by "backporting" some OIDs found in SignatureMechanisms class from itext-dotnet ver.7+ (https://github.com/itext/itext-dotnet/blob/develop/itext/itext.sign/itext/signatures/SignatureMechanisms.cs).