Skip to content

feat: add universal named types decorators#45

Merged
konard merged 5 commits intomainfrom
issue-23-e23fa86d
Apr 30, 2026
Merged

feat: add universal named types decorators#45
konard merged 5 commits intomainfrom
issue-23-e23fa86d

Conversation

@konard
Copy link
Copy Markdown
Member

@konard konard commented Sep 10, 2025

Summary

  • Merged the latest main branch into issue-23-e23fa86d, including the csharp/ and rust/ repository layout.
  • Added C# INamedTypes<TLinkAddress> and NamedTypesDecorator<TLinkAddress> under the new C# project path; the decorator implements links operations through LinksDecoratorBase and named type operations through INamedTypes.
  • Added Rust NamedTypes and NamedTypesDecorator parity for LinkStorage, using a separate names link database and external-reference names.
  • Tightened name cleanup so removing or reassigning names does not leave stale name mappings, and duplicate name assignment moves the name to the latest link.
  • Added C# changeset and Rust changelog fragments for release automation.

Reproduction / Requirement

Issue #23 requests a universal NamedTypesDecorator for ILinks that also implements INamedTypes. After main moved the repository to separate C# and Rust surfaces, the PR also needed equivalent Rust coverage. The new tests cover interface/trait availability, name set/get/reverse lookup/removal, delete cleanup, constructor path behavior, and duplicate-name reassignment.

Tests

  • dotnet test --configuration Release --filter NamedTypesDecorator --verbosity normal (10 passed)
  • dotnet test --configuration Release --verbosity normal (148 passed)
  • cargo fmt --all -- --check
  • RUSTFLAGS=-Dwarnings cargo clippy --all-targets --all-features
  • node scripts/check-file-size.mjs --lang rust
  • cargo test --test named_types_decorator_tests (6 passed)
  • cargo test --all-features --verbose
  • cargo test --doc --verbose

Fixes #23

Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #23
@konard konard self-assigned this Sep 10, 2025
konard and others added 2 commits September 10, 2025 16:36
- Add INamedTypes interface defining naming operations
- Add NamedTypesDecorator implementing both ILinks and INamedTypes
- Add comprehensive test suite for NamedTypesDecorator
- Supports setting, getting, and removing names for link addresses
- Integrates with existing UnicodeStringStorage and NamedLinks infrastructure

Fixes #23

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Add implementation of universal NamedTypes decorator for ILinks Add implementation of universal NamedTypes decorator for ILinks Sep 10, 2025
@konard konard marked this pull request as ready for review September 10, 2025 13:51
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

Get latest changes from default branch.

Double check all everything is correct, and also mirror the same for Rust, add more test cases to ensure 100% tests coverage.

We need to ensure all changes are correct, consistent, validated, tested, logged and fully meet each and all discussed requirements in widest possible sense (check issue description and all comments in issue and in pull request, make sure each and every requirement listed before actually checking if they were addressed). Ensure all CI/CD checks pass.

Please plan and execute everything in a single pull request, you have unlimited time and context, as context autocompacts and you can continue indefinetely, do as much as possible in one go, until it is each and every requirement fully addressed, and everything is totally done.

@konard konard marked this pull request as draft April 30, 2026 07:04
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

🤖 AI Work Session Started

Starting automated work session at 2026-04-30T07:04:02.425Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback.

@konard konard changed the title Add implementation of universal NamedTypes decorator for ILinks feat: add universal named types decorators Apr 30, 2026
@konard konard marked this pull request as ready for review April 30, 2026 07:17
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

Completed this pass on issue-23-e23fa86d and marked the PR ready for review.\n\nSummary:\n- Merged latest main into the branch.\n- Added C# INamedTypes / NamedTypesDecorator under the reorganized csharp/ tree.\n- Added Rust NamedTypes / NamedTypesDecorator parity with tests.\n- Fixed stale/duplicate name cleanup when names are removed or reassigned.\n- Added C# changeset and Rust changelog fragments.\n\nValidation:\n- Local C#: dotnet test --configuration Release --verbosity normal passed, 148 tests.\n- Local Rust: cargo fmt --all -- --check, RUSTFLAGS=-Dwarnings cargo clippy --all-targets --all-features, cargo test --all-features --verbose, and cargo test --doc --verbose passed.\n- GitHub Actions: C# CI/CD Pipeline and Rust CI/CD Pipeline passed for commit 2d13688.

@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.5
  • Provider: OpenAI
  • Public pricing estimate: $9.333745

📊 Context and tokens usage:

  • 6.6M / 1.1M (633%) input tokens, 28.3K / 128K (22%) output tokens

Total: (157.3K + 6.5M cached) input tokens, 28.3K output tokens, $9.333745 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.5
  • Model: GPT-5.5 (gpt-5.5)

📎 Log file uploaded as Repository (32204KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 30, 2026

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard konard merged commit 9b329d3 into main Apr 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add implementation of universal NamedTypes decorator for ILinks

1 participant