mintUpdate.py: Simplify auto-refresh loop and refresh coordination.#1055
Closed
mtwebster wants to merge 3 commits intolinuxmint:masterfrom
Closed
mintUpdate.py: Simplify auto-refresh loop and refresh coordination.#1055mtwebster wants to merge 3 commits intolinuxmint:masterfrom
mtwebster wants to merge 3 commits intolinuxmint:masterfrom
Conversation
- Get rid of refresh-last-run, just rely on the sleep->refresh loop. It was overkill and caused a race condition because the refresh loop is on a thread and the key was being updated on the main loop. - Use threading.Event.wait(), which is interruptible, instead of sleep(), so setting changes can apply immediately, including changing the refresh time and toggling auto-refresh. - Remove the auto-refresh toggle handler, just rely on the settings- change handler. - Collect the thread handles returned from the _async decorator during refresh() to guard refresh_updates()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was overkill and caused a race condition because the refresh
loop is on a thread and the key was being updated on the main loop.
sleep(), so setting changes can apply immediately, including
changing the refresh time and toggling auto-refresh.
change handler.
during refresh() to guard refresh_updates()