Support iconDot for trailing icon in flux:navbar.item and flux:navlist.item#2585
Open
ghabriel25 wants to merge 1 commit intolivewire:mainfrom
Open
Support iconDot for trailing icon in flux:navbar.item and flux:navlist.item#2585ghabriel25 wants to merge 1 commit intolivewire:mainfrom
iconDot for trailing icon in flux:navbar.item and flux:navlist.item#2585ghabriel25 wants to merge 1 commit intolivewire:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
There should be a case when user needs trailing icon with
iconDotfor example in mobile screenNote: There is a difference between trailing icon in
flux:navbar.itemandflux:navlist.item(See #2583)flux:navlist.itemflux:navbar.itemThe problem
Currently,
iconDotonly for leading icon influx:navbar.itemandflux:navlist.itembut not for trailing icon.The solution
Add support
iconDotfor trailing icon match with leading icon. There are no change on how navbar and navlist displayed.Files changed
flux/navbar/item.blade.phpflux/navlist/item.blade.php