Skip to content

⚡ perf: index review summaries by entity_id for O(1) lookup#40737

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:perf/review-index-summary-lookup
Open

⚡ perf: index review summaries by entity_id for O(1) lookup#40737
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:perf/review-index-summary-lookup

Conversation

@lbajsarowicz
Copy link
Copy Markdown
Contributor

Summary

  • Replace O(n²) nested foreach in Review::appendSummary() with pre-indexed associative array for O(n) total complexity.
  • Summaries are indexed by entity_pk_value before the product loop, then looked up via isset() instead of scanning all summaries per product.
  • Behavior is identical: matching products get the summary, non-matching products get an empty DataObject.

Performance Impact

Metric Before After
Complexity O(n × m) nested foreach O(n + m) with indexed lookup
100 products × 100 summaries 10,000 comparisons 200 iterations

Test Plan

  • Unit test with DataProvider covering:
    • Products with matching summaries
    • Products with no matching summary (empty DataObject fallback)
    • Empty summary collection
  • PHPCS clean (requires CI)
  • PHPStan clean (requires CI)

Ref: #40717

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

Replace O(n²) nested foreach in appendSummary() with pre-indexed
associative array for O(n) total complexity.

Ref: magento#40717
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Apr 14, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Copy Markdown
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

2 participants