measurable types are not pointed by default any more#1949
measurable types are not pointed by default any more#1949affeldt-aist merged 3 commits intomath-comp:masterfrom
Conversation
|
The patch we merged to MathComp, i.e., the addition of the following HB.factory Record SubPzRing_isSubComPzRing (R : comPzRingType) S U
& SubPzRing R S U := {}.
HB.builders Context R S U & SubPzRing_isSubComPzRing R S U.
HB.instance Definition _ := SubSemiRing_isSubComSemiRing.Build R S U.
HB.end.does not seem to be complete. The error is now: I tested locally and this is indeed the error one gets Note that another way to make it work is to add I'll do more local checks unless somebody can spot the right fix. |
|
This PR is a strict generalization, solving an issue, and MathComp master has been patch so that the CI is green (and more fixes/improvements are on their way on the MathComp side). I will merge soon unless somebody spots a problem. |
Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
Motivation for this change
fixes #796
fyi: @shinya-katsumata @CohenCyril
We would like this change to be reflected in master as soon as possible so as to be able to work
with the following definition:
Structure distr := Distr { mu :> T -> R ; _ : forall x, 0 <= mu x ; _ : summable [set: T] (EFin \o mu) ; _ : \int[@counting (discrete_measurable_space T) R]_x (mu x) <= 1 }.without requiring
Tto be apointedType, only achoiceType,to preserve the generality of
distrfrom theexperimental_realspackage@strub @lyonel2017 (just substituting
summableandpsumfrom theirMathComp-Analysis equivalent to use the library more easily).
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers