fix: pass context to all http requests in microcks and keycloak clients#263
Open
mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
Open
fix: pass context to all http requests in microcks and keycloak clients#263mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
mugiwaraluffy56 wants to merge 1 commit intomicrocks:masterfrom
Conversation
Signed-off-by: puneeth_aditya_5656 <myakampuneeth@gmail.com>
2865142 to
f1c7080
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all http requests in
MicrocksClientandKeycloakClientwere built withhttp.NewRequest, which doesn't accept a context. this means there's no way to cancel an in-flight request from the caller side — if a call hangs, it just hangs.switched everything over to
http.NewRequestWithContextand addedcontext.Contextas the first parameter to all interface methods that make http calls. callers incmd/passcontext.Background()for now, which keeps behaviour identical while making it possible to wire up proper timeouts later (e.g. in the polling loop incmd/test.go).files changed:
pkg/connectors/microcks_client.go— updatedMicrocksClientinterface and all five method implementationspkg/connectors/keycloak_client.go— updatedKeycloakClientinterface and all three method implementationspkg/watcher/executor.go— updatedUploadArtifactcallcmd/importDir.go— updated localMicrocksClientinterface andImportDirectorysignaturecmd/importDir_test.go— updated mock and test calls to matchcmd/import.go,cmd/importURL.go,cmd/test.go— passcontext.Background()at call sitescmd/login.go— threadscmd.Context()through to all keycloak and microcks callsnote: this is a breaking change to the
MicrocksClientandKeycloakClientinterface signatures. any code outside this repo that implements or calls these interfaces will need to be updated.