fix(themes): don't leak custom theme css after preview (@fehmer)#7876
Open
fix(themes): don't leak custom theme css after preview (@fehmer)#7876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7875
Slow network connections caused the theme css to be applied on the #customTheme stylesheet link element after clearing the theme preview with
href="".Empty href is invalid, so best to remove the whole element if we don't need it:
https://html.spec.whatwg.org/multipage/semantics.html#attr-link-href
While chrome is applying the last css file firefox removes it correctly but keeps the loaderBar active because of the missing onLoad callback