feat(oauth): restore update flow and handle new inbound members#314
feat(oauth): restore update flow and handle new inbound members#314codingLogan wants to merge 5 commits intomasterfrom
Conversation
codingLogan
requested review from
Jameson13B,
ash-wright123,
mwclemy and
wesrisenmay-mx
as code owners
|
This kind of a change makes me really wish we had better E2E tests. |
| } | ||
|
|
||
| function handleOAuthSuccess(memberGuid) { | ||
| function handleOAuthSuccess(memberGuid, member = null) { |
There was a problem hiding this comment.
I think it would be clearer if we explicitly distinguished between the inbound member and the original member here. Better naming would make the flow easier to follow and maintain for future devs.
There was a problem hiding this comment.
The memberGuid and the member are always going to be related to each other. If member is populated we can update our store with that data for that memberGuid. It may be the outbound or inbound member in other words.
There was a problem hiding this comment.
Okay, so does that mean we can’t tell which one is which at this point?
There was a problem hiding this comment.
From what I can see in the code, memberGuid looks like it's a different member that may be returned from the backend during the OAuth process, while member is the original member. Might be worth renaming these to make the distinction clearer, since the current names are a bit ambiguous.
3 participants
https://mxcom.atlassian.net/browse/CTT-178
This re-introduces the "update" path for OAuth members. See the above internal Jira for more details