Skip to content

chore: Move @n8n/tournament to catalog and bump to 1.0.7#28890

Open
ivov wants to merge 1 commit intomasterfrom
chore-tournament-catalog-bump
Open

chore: Move @n8n/tournament to catalog and bump to 1.0.7#28890
ivov wants to merge 1 commit intomasterfrom
chore-tournament-catalog-bump

Conversation

@ivov
Copy link
Copy Markdown
Member

@ivov ivov commented Apr 22, 2026

  • I have seen this code, I have run this code, and I take responsibility for this code.

@ivov ivov requested a review from despairblue April 22, 2026 10:56
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Architecture diagram
sequenceDiagram
    participant W as Workflow Service
    participant ER as Expression Runtime
    participant T as @n8n/tournament (v1.0.7)
    participant IVM as isolated-vm

    Note over W,T: NEW: Unified Dependency Version via pnpm catalog

    W->>W: Process Workflow Node
    
    rect rgb(240, 240, 240)
        Note right of W: Internal Workflow Logic
        W->>T: CHANGED: Execute tournament logic
        T-->>W: Return resolution
    end

    W->>ER: evaluateExpression(string)
    
    ER->>IVM: Create Sandbox Context
    
    rect rgb(240, 240, 240)
        Note right of ER: Runtime Evaluation Logic
        ER->>T: CHANGED: Resolve expression tournament
        T-->>ER: Return logic result
    end

    ER-->>W: Return evaluated value
    W->>W: Continue Execution Flow
Loading

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant Bot added n8n team Authored by the n8n team core Enhancement outside /nodes-base and /editor-ui labels Apr 22, 2026
@ivov ivov enabled auto-merge April 22, 2026 14:13
@github-actions
Copy link
Copy Markdown
Contributor

Performance Comparison

Comparing currentlatest master14-day baseline

Idle baseline with Instance AI module loaded

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-heap-used-baseline 186.78 MB 186.50 MB 186.43 MB (σ 0.25) +0.2% +0.2% ⚠️
instance-ai-rss-baseline 345.52 MB 392.12 MB 368.35 MB (σ 22.82) -11.9% -6.2% ⚠️

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-heap-used-baseline 114.53 MB 114.27 MB 114.47 MB (σ 0.24) +0.2% +0.1%
memory-rss-baseline 350.97 MB 348.40 MB 289.80 MB (σ 40.90) +0.7% +21.1% ⚠️

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-runners 387.00 MB 386.00 MB 392.13 MB (σ 11.18) +0.3% -1.3%
docker-image-size-n8n 1269.76 MB 1269.76 MB 1273.60 MB (σ 10.49) +0.0% -0.3%
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Bundle Report

Changes will increase total bundle size by 154.93kB (0.34%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
editor-ui-esm 45.92MB 154.93kB (0.34%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/typescript.worker-*.js -12.25kB 10.87MB -0.11%
assets/constants-*.js 179.44kB 3.32MB 5.71% ⚠️
assets/worker-*.js -12.26kB 3.15MB -0.39%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants