fix(editor): Fix column collapse button not visible in table view#28899
Open
RicardoE105 wants to merge 1 commit intomasterfrom
Open
fix(editor): Fix column collapse button not visible in table view#28899RicardoE105 wants to merge 1 commit intomasterfrom
RicardoE105 wants to merge 1 commit intomasterfrom
Conversation
The N8nTooltip migration from Element Plus to reka-ui introduced a <span> wrapper around tooltip triggers. The broad `.header span` CSS rule applied `overflow: hidden` to this new wrapper, clipping the collapse button due to its negative block margins. - Scope `.header span` to `> :first-child` so only the text element gets truncation styles, not the tooltip trigger wrapper - Remove negative `margin-block` on the collapse button that caused clipping inside the tooltip wrapper span
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
fIxes #26393 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<span>wrapper around tooltip triggers. The broad.header spanCSS rule appliedoverflow: hiddento this wrapper, clipping the collapse button> :first-childso only the text element gets truncation stylesmargin-blockon the collapse button that caused clipping and vertical misalignment inside the tooltip wrapperRelated ticket
https://linear.app/n8n/issue/ADO-4971
Test plan
Import this workflow, execute it, then open the Edit Fields node output in Table view:
Test workflow JSON
{ "nodes": [ { "parameters": {}, "type": "n8n-nodes-base.manualTrigger", "typeVersion": 1, "position": [0, 0], "id": "94cbfb22-8799-4f3b-af5f-3c189d46123a", "name": "When clicking 'Execute workflow'" }, { "parameters": { "mode": "raw", "options": {} }, "type": "n8n-nodes-base.set", "typeVersion": 3.4, "position": [208, 0], "id": "43d672db-f2d0-443e-9a63-cf8a260fa82b", "name": "Edit Fields" } ], "connections": { "When clicking 'Execute workflow'": { "main": [ [ { "node": "Edit Fields", "type": "main", "index": 0 } ] ] } }, "pinData": { "When clicking 'Execute workflow'": [ { "name": "First item", "code": 1, "data": {"some": "a", "large": "b", "json": "c", "object": "d", "with": "e", "many": "f", "keys": "g"} }, { "name": "Second item", "code": 2, "data": {"some": "n", "large": "m", "json": "o", "object": "p", "with": "q", "many": "r", "keys": "s"} }, { "name": "Third item", "code": 3, "data": {"some": "x", "large": "y", "json": "z", "object": "w", "with": "v", "many": "u", "keys": "t"} }, { "name": "Third item", "code": 3, "data": {"some": "x", "large": "y", "json": "z", "object": "w", "with": "v", "many": "u", "keys": "t"} }, { "name": "Third item", "code": 3, "data": {"some": "x", "large": "y", "json": "z", "object": "w", "with": "v", "many": "u", "keys": "t"} }, { "name": "Third item", "code": 3, "data": {"some": "x", "large": "y", "json": "z", "object": "w", "with": "v", "many": "u", "keys": "t"} }, { "name": "Third item", "code": 3, "data": {"some": "x", "large": "y", "json": "z", "object": "w", "with": "v", "many": "u", "keys": "t"} } ] } }