Merged
Conversation
victorlin
commented
Apr 30, 2026
victorlin
force-pushed
the
victorlin/update-python-versions
branch
2 times, most recently
from
b1594df to
a6a479c
Compare
victorlin
force-pushed
the
victorlin/update-python-versions
branch
from
a6a479c to
59ad251
Compare
Subsequent commits will remove the 3.8 and 3.9-specific workarounds.
Removed two now-unnecessary ignore markers. Also added an explicit flush() method to LinePrefixer (reasoning in comment).
Versions no longer supported.
Python 3.9 is no longer supported so this workaround is no longer needed.
Both TypeAlias and EllipsisType are available in the standard library in all supported Python versions.
urllib3 isn't used directly by the code so I'm not sure why these were added. Removing them to get rid of the Python 3.8 and 3.9 specific dependencies.
This reverts "Suppress warning from cryptography about deprecated Python 3.8 support" (8987cfd) since 3.8 is no longer supported.
This function is now available in all supported Python versions.
victorlin
force-pushed
the
victorlin/update-python-versions
branch
from
59ad251 to
92afffc
Compare
joverlee521
reviewed
May 4, 2026
Contributor
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Thanks for pushing through this, changes here look good to me. Could you remove one last Python 3.9 workaround?
These functions are now available in all supported Python versions.
The title from argparse is now the same for all supported Python versions. Keeping the variable around because it is used in multiple places.
Python 3.9 is no longer supported.
victorlin
force-pushed
the
victorlin/update-python-versions
branch
from
92afffc to
bd7fb42
Compare
Member
Author
|
@joverlee521 nice catch, done in 5833403 |
joverlee521
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Drop support for end of life Python versions 3.8 and 3.9.
Changes broken into multiple commits to follow the pattern in #325.
Related issue(s)
Checklist