Skip to content

Update seqsero2: topic versions, stub block, sanitizeOutput#11446

Open
HReed1 wants to merge 3 commits intonf-core:masterfrom
HReed1:stub-topics-seqsero2
Open

Update seqsero2: topic versions, stub block, sanitizeOutput#11446
HReed1 wants to merge 3 commits intonf-core:masterfrom
HReed1:stub-topics-seqsero2

Conversation

@HReed1
Copy link
Copy Markdown
Contributor

@HReed1 HReed1 commented Apr 30, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool, add --profile docker,wave tests.
  • Make sure your code lints (nf-core modules lint).
  • Ensure the test suite passes (nf-test test).

Description of changes

Migrates the seqsero2 module to the nf-core v4.0.1 architecture:

  • topic: versions: Replaced legacy versions.yml file emission with dynamic eval() tuple emission on the topic: versions channel.
  • stub block: Added a deterministic stub: block for CI/CD stub-run support.
  • sanitizeOutput: Refactored all test assertions to use sanitizeOutput(process.out) per nf-test best practices.
  • meta.yml: Updated to include both output: versions_seqsero2 and topics: versions sections.

Part of the v4.0.1 standardization effort tracked in #11323.

process.out.versions
).match()
}
{ assert snapshot(sanitizeOutput(process.out)).match() }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't just blindly use sanitizeOutput on process.out when we weren't before!

@HReed1 HReed1 force-pushed the stub-topics-seqsero2 branch from a99314b to 3c453f9 Compare May 1, 2026 12:07
- main.nf: emit: versions -> emit: versions_seqsero2
- meta.yml: output key versions: -> versions_seqsero2:
- tests/main.nf.test.snap: regenerate snapshots

Local lint: 52/0. Local nf-test: 2/2 passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants