Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Reviewed by Cursor Bugbot for commit f23ba96. Bugbot is set up for automated code reviews on this repo. Configure here. |
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f23ba96. Configure here.
|
|
||
| // TODO(@avivkeller): Find a way to enable Twoslash w/ a VFS on Cloudflare | ||
| twoslash: !OPEN_NEXT_CLOUDFLARE, | ||
| twoslash: true, |
There was a problem hiding this comment.
Twoslash enabled on Cloudflare despite known incompatibility
High Severity
The twoslash option is now hardcoded to true, removing the !OPEN_NEXT_CLOUDFLARE guard that previously disabled it on Cloudflare Workers. The removed TODO comment explicitly noted that Twoslash with a VFS doesn't work on Cloudflare. Since the wasm option on the line above still uses the !OPEN_NEXT_CLOUDFLARE conditional for an analogous Cloudflare limitation, this change breaks consistency and will likely cause failures when running on Cloudflare Workers.
Reviewed by Cursor Bugbot for commit f23ba96. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8835 +/- ##
==========================================
+ Coverage 73.88% 73.91% +0.02%
==========================================
Files 105 105
Lines 8889 8889
Branches 326 326
==========================================
+ Hits 6568 6570 +2
+ Misses 2320 2318 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR appears to be a WIP change to enable Twoslash-based Shiki transformations in the site’s MDX pipeline (apps/site), likely for testing.
Changes:
- Enable
twoslashin the MDX Shiki (rehype-shiki) plugin configuration unconditionally (including Cloudflare builds).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // TODO(@avivkeller): Find a way to enable Twoslash w/ a VFS on Cloudflare | ||
| twoslash: !OPEN_NEXT_CLOUDFLARE, | ||
| twoslash: true, |
There was a problem hiding this comment.
twoslash is now enabled unconditionally. This file previously disabled Twoslash on Cloudflare specifically because it needs a VFS / Node-like filesystem support there, and nothing else in this PR adds that missing support. As-is, Cloudflare worker builds/runtime MDX compilation are likely to fail (or significantly increase CPU/memory) when Twoslash runs. Please gate Twoslash behind !OPEN_NEXT_CLOUDFLARE again or add a Cloudflare-compatible VFS/feature flag that keeps Cloudflare deployments off by default.
| twoslash: true, | |
| // Twoslash needs Node-like filesystem/VFS support and is disabled on | |
| // Cloudflare workers until a compatible implementation is available. | |
| twoslash: !OPEN_NEXT_CLOUDFLARE, |
|
It doesn't seem to be working, does it? 😕 I tried deploying it and this is what I got: (PS: I'm not sure why the missing CSS there though 😕) |
No description provided.