fix: add validation for empty dataset name#1287
Open
Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Open
fix: add validation for empty dataset name#1287Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Shamarvey1 wants to merge 1 commit intoopenml:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Missing error message on blank dataset name (#1191)
Problem
Currently, it is possible to upload a dataset without providing a name. Since the dataset name is a mandatory field, this leads to invalid dataset entries.
Solution
Added validation in the
data_upload()function to check if the dataset name is empty usingempty(trim($name)).Changes
Expected Behavior
Notes
This ensures backend validation even if frontend validation is bypassed.