Remove hard cap and honor configured retry intervals#231
Merged
Conversation
The retry limit was silently clamped to the policy default, configured intervals were ignored by delay calculators, and the async reconnection loop never checked the limit or advanced its counter — fix all three and add a `maximum_reconnection_interval` config option. refactor(publish): remove client-side publish sequence number (`seqn`) `seqn` is not required by PubNub REST API, so remove `PublishSequenceManager`, all its subclasses, `MAX_SEQUENCE`, and `seqn` injection. test(reconnection): rewrite and expand reconnection and effect delay tests Cover `LinearDelay`, `ExponentialDelay`, `ReconnectionManager`, `ReconnectEffect`, and `HeartbeatDelayedEffect` with deterministic assertions for default, custom, and edge cases
parfeon
added
status: done
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
jguz-pubnub
approved these changes
Apr 20, 2026
Contributor
Author
|
@pubnub-release-bot release |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(reconnection): remove hard cap and honor configured retry intervals
The retry limit was silently clamped to the policy default, configured intervals were ignored by delay calculators, and the async reconnection loop never checked the limit or advanced its counter — fix all three and add a
maximum_reconnection_intervalconfig option.refactor(publish): remove client-side publish sequence number (
seqn)seqnis not required by PubNub REST API, so removePublishSequenceManager, all its subclasses,MAX_SEQUENCE, andseqninjection.test(reconnection): rewrite and expand reconnection and effect delay tests
Cover
LinearDelay,ExponentialDelay,ReconnectionManager,ReconnectEffect, andHeartbeatDelayedEffectwith deterministic assertions for default, custom, and edge cases