Conversation
...removing the need to use --enable-incomplete-feature=TypeForm
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
|
||
| [case testRecognizesParameterizedTypeFormInAnnotation] | ||
| # flags: --python-version 3.14 --enable-incomplete-feature=TypeForm | ||
| # flags: --python-version 3.15 |
There was a problem hiding this comment.
hm do we already support 3.15 enough for this to make sense? The test uses typing_extensions anyway so I'm not sure why it needs to pin a version at all.
There was a problem hiding this comment.
The test uses typing_extensions anyway so I'm not sure why it needs to pin a version at all.
If it's OK for the test to (A) continue to use typing_extensions, then I agree that the --python-version 3.15 doesn't make a lot of sense.
OTOH, if it would be more conventional in tests to (B) use the typing version, then I think --python-version 3.15 becomes necessary.
I'll take a look in the next few days to see what other tests are doing to choose whether to do (A) or (B).
...removing the need to use --enable-incomplete-feature=TypeForm
REVIEWER NOTES: