Skip to content

TypeForm: Enable by default#21262

Open
davidfstr wants to merge 1 commit intopython:masterfrom
davidfstr:f/typeform_complete
Open

TypeForm: Enable by default#21262
davidfstr wants to merge 1 commit intopython:masterfrom
davidfstr:f/typeform_complete

Conversation

@davidfstr
Copy link
Copy Markdown
Contributor

...removing the need to use --enable-incomplete-feature=TypeForm


REVIEWER NOTES:

...removing the need to use --enable-incomplete-feature=TypeForm
@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅


[case testRecognizesParameterizedTypeFormInAnnotation]
# flags: --python-version 3.14 --enable-incomplete-feature=TypeForm
# flags: --python-version 3.15
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm do we already support 3.15 enough for this to make sense? The test uses typing_extensions anyway so I'm not sure why it needs to pin a version at all.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test uses typing_extensions anyway so I'm not sure why it needs to pin a version at all.

If it's OK for the test to (A) continue to use typing_extensions, then I agree that the --python-version 3.15 doesn't make a lot of sense.

OTOH, if it would be more conventional in tests to (B) use the typing version, then I think --python-version 3.15 becomes necessary.

I'll take a look in the next few days to see what other tests are doing to choose whether to do (A) or (B).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants