Update trainingyt.py: Migrate to transforms.v2, f-strings, and modern syntax#3871
Update trainingyt.py: Migrate to transforms.v2, f-strings, and modern syntax#3871Sai-prashanth-2006 wants to merge 4 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3871
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Claude finished @sekyondaMeta's task in 3m 39s —— View job Review: PR #3871 vs Issue #3858
SummaryThis PR aims to fix issue #3858 (deprecation of Critical Issue: Incorrect ImportFile: # What the PR does (WRONG):
import torchvision.transforms as v2
# What it should be:
from torchvision.transforms import v2The PR simply renames the alias of the old The correct pattern (already used in this repo at from torchvision.transforms import v2Minor Issue: Pointless f-stringFile: # PR changes this:
print(' '.join(classes[labels[j]] for j in range(4)))
# To this:
print(' '.join(f'{classes[labels[j]]}' for j in range(4)))Wrapping What's Correct
Comparison to Issue #3858Based on the PR description, issue #3858 requests fixing the deprecated VerdictNeeds changes before merge:
|
|
thanks for catching that, import fixed and f-string reverted |
Fixes #3858
Description
This PR modernizes
trainingyt.pyby resolving deprecated API usage and aligning the codebase with current Python and PyTorch best practices:torchvision.transformspipeline to thev2API, replacing the deprecatedToTensortransformGarmentClassifier.__init__to use the Python 3super().__init__()syntax.format()string literals with f-strings for improved readability and performanceNo functional behavior is changed by this PR.
Checklist