Fix wrongly installing testing directory#682
Conversation
The fix for trentm#655 introduced a regression: the package now installs a `/usr/testing` directory. Fix the issue correctly by adding the file to the source distribution via `MANIFEST.in`. Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
Thanks! I'll do some testing against test pypi site. Is this just an annoyance right now or is it actually breaking something? |
|
Annoyance. I've already patched the Gentoo package to remove the directory. |
|
Doing some testing with this. Looks to indeed fix the issue and also include the tox.ini in the resulting tar.gz on pypi, but does not seem to be available when pip installing. Paging @mtelka this was originally your ask to have this included, where/how are you trying to use the tox.ini assuming its added to the uploaded package? |
|
The OP mentioned "sdist" and "downstream testing", so it's going to be used after unpacking the sdist. |
Yes, exactly. The |
|
Sorry for delay. Did some more checks and I think this PR will indeed fix it. |
3 participants
The fix for #655 introduced a regression: the package now installs a
/usr/testingdirectory. Fix the issue correctly by adding the file to the source distribution viaMANIFEST.in.