Skip to content

tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is modified#16916

Merged
parthea merged 3 commits intomainfrom
update-system-test-config
May 4, 2026
Merged

tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is modified#16916
parthea merged 3 commits intomainfrom
update-system-test-config

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented May 1, 2026

Fixes #16905

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .kokoro/system.sh script to use an array for files_to_check, expanding the set of files monitored for changes to include setup.py, pyproject.toml, and versioning files. It is recommended to use the --name-only flag with git diff to improve efficiency, as the script only requires a count of changed files rather than the full diff content.

Comment thread .kokoro/system.sh
@parthea parthea changed the title tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is changed tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is modified May 1, 2026
This reverts commit 936e27d.
@parthea parthea marked this pull request as ready for review May 4, 2026 15:02
@parthea parthea requested a review from a team as a code owner May 4, 2026 15:02
@parthea parthea merged commit 199ef25 into main May 4, 2026
30 checks passed
@parthea parthea deleted the update-system-test-config branch May 4, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System tests not running in latest Release PR

3 participants