tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is modified#16916
Merged
tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is modified#16916
CHANGELOG is modified#16916Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .kokoro/system.sh script to use an array for files_to_check, expanding the set of files monitored for changes to include setup.py, pyproject.toml, and versioning files. It is recommended to use the --name-only flag with git diff to improve efficiency, as the script only requires a count of changed files rather than the full diff content.
CHANGELOG is changedCHANGELOG is modified
This reverts commit 936e27d.
ohmayr
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16905