Skip to content

tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is modified #16916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 3 commits into from
May 4, 2026
Merged

tests: ensure system test presubmit runs in release PRs regardless if CHANGELOG is modified #16916

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152d271
tests: ensure system test script runs in release PRs
parthea May 1, 2026
936e27d
test trigger
parthea May 1, 2026
a170d24
Revert "test trigger"
parthea May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .kokoro/system.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,24 @@ for path in `find 'packages' \
package_path="packages/${package_name}"

# Determine if we should skip based on git diff
files_to_check="${package_path}/CHANGELOG.md"
# We always check for changes in these specific versioning/config files
files_to_check=(
"${package_path}/CHANGELOG.md"
"${package_path}/setup.py"
"${package_path}/pyproject.toml"
"${package_path}/**/gapic_version.py"
"${package_path}/**/version.py"
)

# If the package is in our "always run full system tests" list, check the whole directory
if [[ $package_name == @($packages_with_system_tests_pattern) ]]; then
files_to_check="${package_path}"
files_to_check=("${package_path}")
fi

echo "checking changes with 'git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- ${files_to_check}'"
echo "checking changes with 'git diff ${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT} -- ${files_to_check[*]}'"
set +e
package_modified=$(git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- ${files_to_check} | wc -l)
# Passing the array expanded as arguments to git diff
package_modified=$(git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- "${files_to_check[@]}" | wc -l)
Comment thread
parthea marked this conversation as resolved.
set -e

if [[ "${package_modified}" -gt 0 || "$KOKORO_BUILD_ARTIFACTS_SUBDIR" == *"continuous"* ]]; then
Expand Down
Loading